Enable GPIO Pin Interrupts #1922
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzrd
force-pushed
the
lpc55-gpio-interrupts
branch
2 times, most recently
from
ddf4058 to
8565d73
Compare
labbott
reviewed
Nov 19, 2024
build/lpc55pins/src/lib.rs
Outdated
| writeln!(&mut buf, "#[allow(unused)]")?; | ||
| writeln!( | ||
| &mut buf, | ||
| "pub const {}_PINT_MASK: u32 = 1 << {};", |
There was a problem hiding this comment.
Passing the raw mask around doesn't seem right and you have a comment below about wanting to validate the mask. Can we pass the PintSlot enum around instead? That should always be valid.
lzrd
force-pushed
the
lpc55-gpio-interrupts
branch
from
8565d73 to
70ecce9
Compare
Add interrupt-related API calls to the LPC55 `gpio_driver`.
A task on an LPC55 can now configue and use GPIO interrupts.
app.toml example shows Pin Interrupt configuration:
[tasks.foo]
...
interrupts = { "pint.irq0" = "button-irq" }
...
task-slots = ["gpio_driver", ...]
[tasks.foo.config]
pins = [
{ name="BUTTON', pin={ port=1, pin=9}, alt=0, pint=0, direction="input", opendrain="normal" }
]
…API.
The functions:
fn {clear,detected,disable,enable}_{rising,falling,status}(PintSlot)
and
fn read_pint_status(...)
become
fn pint_op(PintSlot, PintOp, PintCondition)
This leaves a couple permutations not covered (enable/disable
interrupt at the NVIC level).
Those can are left as no-ops for the time being.
Future: The unimplemented combinations could return an error/fault
if called.
…EADME.md Feedback response: Fix idl/lpc55-pins.idol to use Option<PintSlot>. Feedback response: Collapse the many PINT calls in lpc55-pins.idol to one `pint_op`
lzrd
force-pushed
the
lpc55-gpio-interrupts
branch
from
70ecce9 to
77e17fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add interrupt-related API calls to the LPC55
gpio_driver.Also:
Fix app/gimletlet/app-mgmt.toml stack size which was found while building all targets.
A task on an LPC55 can now configue and use GPIO interrupts.
app.toml example shows Pin Interrupt configuration:
[tasks.foo]
...
interrupts = { "pint.irq0" = "button-irq" }
...
task-slots = ["gpio_driver", ...]
[tasks.foo.config]
pins = [
{ name="BUTTON', pin={ port=1, pin=9}, alt=0, pint=0, direction="input", opendrain="normal" }
]